diff --git a/libraries/common/build.gradle b/libraries/common/build.gradle index 71184f5da1..3842e8f02f 100644 --- a/libraries/common/build.gradle +++ b/libraries/common/build.gradle @@ -35,6 +35,11 @@ android { lint { baseline = file("lint-baseline.xml") } + lintOptions { + // TODO: b/353490583 - Move this to common_library_config.gradle once it's enabled for all + // libraries. + checkTestSources true + } publishing { singleVariant('release') { withSourcesJar() diff --git a/libraries/common/src/test/java/androidx/media3/common/MediaItemTest.java b/libraries/common/src/test/java/androidx/media3/common/MediaItemTest.java index 48cc54a94c..c3400594c5 100644 --- a/libraries/common/src/test/java/androidx/media3/common/MediaItemTest.java +++ b/libraries/common/src/test/java/androidx/media3/common/MediaItemTest.java @@ -557,6 +557,7 @@ public class MediaItemTest { } @Test + @SuppressWarnings("Range") // Deliberately testing invalid values public void clippingConfigurationBuilder_throwsOnInvalidValues() { MediaItem.ClippingConfiguration.Builder clippingConfigurationBuilder = new MediaItem.ClippingConfiguration.Builder(); @@ -582,7 +583,7 @@ public class MediaItemTest { } @Test - @SuppressWarnings("deprecation") // Testing deprecated setter. + @SuppressWarnings({"deprecation", "Range"}) // Testing deprecated setter with invalid value. public void builderSetStartPositionMs_negativeValue_throws() { MediaItem.Builder builder = new MediaItem.Builder(); diff --git a/libraries/common/src/test/java/androidx/media3/common/util/ColorParserTest.java b/libraries/common/src/test/java/androidx/media3/common/util/ColorParserTest.java index 4791df0905..b7e12c6521 100644 --- a/libraries/common/src/test/java/androidx/media3/common/util/ColorParserTest.java +++ b/libraries/common/src/test/java/androidx/media3/common/util/ColorParserTest.java @@ -79,6 +79,7 @@ public final class ColorParserTest { @Test public void rgbColorParsingRgbValuesOutOfBounds() { int outOfBounds = ColorParser.parseTtmlColor("rgb(999, 999, 999)"); + @SuppressWarnings("Range") // Deliberately testing invalid values int color = Color.rgb(999, 999, 999); // Behave like the framework does. assertThat(outOfBounds).isEqualTo(color); diff --git a/libraries/lint.xml b/libraries/lint.xml index 171f44b064..2895e7d286 100644 --- a/libraries/lint.xml +++ b/libraries/lint.xml @@ -17,4 +17,9 @@ + + + + diff --git a/libraries/session/src/test/lint.xml b/libraries/session/src/test/lint.xml deleted file mode 100644 index c73f9eaa61..0000000000 --- a/libraries/session/src/test/lint.xml +++ /dev/null @@ -1,21 +0,0 @@ - - - - - -