From ac67f739d4c68203a0dd86c0cdc997078f980345 Mon Sep 17 00:00:00 2001 From: sheenachhabra Date: Fri, 8 Dec 2023 09:18:07 -0800 Subject: [PATCH] Specify which input file has B-frames in Transformer demo app For out of order B-frames, the samples comes out of order and hence presentation timestamps are not strictly increasing. This can be verified by adding following assertion in `writeSampleData()` API either in `MuxerWrapper` or in `Muxer API`. ``` checkArgument( bufferInfo.presentationTimeUs > lastSamplePresentationTimeUs, "Out of order B-frames are not supported"); ``` PiperOrigin-RevId: 589152093 --- .../media3/demo/transformer/ConfigurationActivity.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/demos/transformer/src/main/java/androidx/media3/demo/transformer/ConfigurationActivity.java b/demos/transformer/src/main/java/androidx/media3/demo/transformer/ConfigurationActivity.java index a6b2d9c657..cc6f1c104f 100644 --- a/demos/transformer/src/main/java/androidx/media3/demo/transformer/ConfigurationActivity.java +++ b/demos/transformer/src/main/java/androidx/media3/demo/transformer/ConfigurationActivity.java @@ -147,8 +147,8 @@ public final class ConfigurationActivity extends AppCompatActivity { "https://storage.googleapis.com/exoplayer-test-media-1/mp4/sample_video_track_only.mp4", }; private static final String[] PRESET_FILE_URI_DESCRIPTIONS = { // same order as PRESET_FILE_URIS - "720p H264 video and AAC audio", - "1080p H265 video and AAC audio", + "720p H264 video and AAC audio (B-frames)", + "1080p H265 video and AAC audio (B-frames)", "360p H264 video and AAC audio", "360p VP8 video and Vorbis audio", "4K H264 video and AAC audio (portrait, no B-frames)", @@ -163,7 +163,7 @@ public final class ConfigurationActivity extends AppCompatActivity { "480p DASH (non-square pixels)", "HDR (HDR10) H265 limited range video (encoding may fail)", "HDR (HLG) H265 limited range video (encoding may fail)", - "720p H264 video with no audio", + "720p H264 video with no audio (B-frames)", }; private static final String[] AUDIO_EFFECTS = { "High pitched",