From a5d43b2194bf384c0534deb75f5e4fbae24aca27 Mon Sep 17 00:00:00 2001 From: huangdarwin Date: Thu, 26 Jan 2023 11:20:12 +0000 Subject: [PATCH] Effect: Clarify that padding is added in ScaleToFitTransformation. PiperOrigin-RevId: 504796380 --- .../java/androidx/media3/effect/GlMatrixTransformation.java | 2 +- .../androidx/media3/effect/ScaleToFitTransformation.java | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libraries/effect/src/main/java/androidx/media3/effect/GlMatrixTransformation.java b/libraries/effect/src/main/java/androidx/media3/effect/GlMatrixTransformation.java index 812b0f48fb..624ecfbc62 100644 --- a/libraries/effect/src/main/java/androidx/media3/effect/GlMatrixTransformation.java +++ b/libraries/effect/src/main/java/androidx/media3/effect/GlMatrixTransformation.java @@ -23,7 +23,7 @@ import androidx.media3.common.util.UnstableApi; import com.google.common.collect.ImmutableList; /** - * Specifies a 4x4 transformation {@link Matrix} to apply in the vertex shader for each frame. + * Specifies a 4x4 transformation {@link Matrix} to apply in the vertex shader for each input frame. * *

The matrix is applied to points given in normalized device coordinates (-1 to 1 on x, y, and z * axes). Transformed pixels that are moved outside of the normal device coordinate range are diff --git a/libraries/effect/src/main/java/androidx/media3/effect/ScaleToFitTransformation.java b/libraries/effect/src/main/java/androidx/media3/effect/ScaleToFitTransformation.java index 15d879115f..ff0bfa7d0f 100644 --- a/libraries/effect/src/main/java/androidx/media3/effect/ScaleToFitTransformation.java +++ b/libraries/effect/src/main/java/androidx/media3/effect/ScaleToFitTransformation.java @@ -74,9 +74,9 @@ public final class ScaleToFitTransformation implements MatrixTransformation { * *

The default value, 0, corresponds to not applying any rotation. * - *

The output frame's width and height are automatically adjusted to preserve all input - * pixels. The rotated input frame is fitted inside an enclosing black rectangle if its edges - * aren't parallel to the x and y axes. + *

The output frame's width and height are adjusted to preserve all input pixels. The rotated + * input frame is fitted inside an enclosing black rectangle if its edges aren't parallel to the + * x and y axes, to form the output frame. * * @param rotationDegrees The counterclockwise rotation, in degrees. * @return This builder.