From a4f67ccf6a17e18d118a39eeec4026aa496f240e Mon Sep 17 00:00:00 2001 From: ibaker Date: Mon, 13 Dec 2021 12:56:55 +0000 Subject: [PATCH] Change DefaultHttpDataSourceTest to an instrumentation test The Robolectric implementation of HttpURLConnection forwards to the JRE implementation [1], which behaves differently to the Android one available on devices and emulators. For these tests to be a realistic test of the HTTP stack used in real playbacks we can't use Robolectric. Similar to https://github.com/androidx/media/commit/d1e12dcddf0ea6d00a8b0d2df6786e7f06ad7e2f [1] https://github.com/robolectric/robolectric/issues/6769#issuecomment-943556156 PiperOrigin-RevId: 416013662 --- libraries/datasource/build.gradle | 1 + .../androidx/media3/datasource/DefaultHttpDataSourceTest.java | 0 2 files changed, 1 insertion(+) rename libraries/datasource/src/{test => androidTest}/java/androidx/media3/datasource/DefaultHttpDataSourceTest.java (100%) diff --git a/libraries/datasource/build.gradle b/libraries/datasource/build.gradle index 2e4c036f79..7706ffc0b3 100644 --- a/libraries/datasource/build.gradle +++ b/libraries/datasource/build.gradle @@ -42,6 +42,7 @@ dependencies { androidTestImplementation 'androidx.test:runner:' + androidxTestRunnerVersion androidTestImplementation 'com.linkedin.dexmaker:dexmaker:' + dexmakerVersion androidTestImplementation 'com.linkedin.dexmaker:dexmaker-mockito:' + dexmakerVersion + androidTestImplementation 'com.squareup.okhttp3:mockwebserver:' + okhttpVersion androidTestImplementation(project(modulePrefix + 'test-utils')) { exclude module: modulePrefix.substring(1) + 'library-core' } diff --git a/libraries/datasource/src/test/java/androidx/media3/datasource/DefaultHttpDataSourceTest.java b/libraries/datasource/src/androidTest/java/androidx/media3/datasource/DefaultHttpDataSourceTest.java similarity index 100% rename from libraries/datasource/src/test/java/androidx/media3/datasource/DefaultHttpDataSourceTest.java rename to libraries/datasource/src/androidTest/java/androidx/media3/datasource/DefaultHttpDataSourceTest.java