From 9c6d9e9e477c0d06e8a42a100189caadc9cbe53f Mon Sep 17 00:00:00 2001 From: claincly Date: Mon, 18 Nov 2024 10:30:11 -0800 Subject: [PATCH] Reduce test name lengths Some parametrized names are too long (>255 chars). Remove putting parameter info in the test name and instead log them. PiperOrigin-RevId: 697677513 --- .../transformer/ParameterizedInputSequenceExportTest.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libraries/transformer/src/androidTest/java/androidx/media3/transformer/ParameterizedInputSequenceExportTest.java b/libraries/transformer/src/androidTest/java/androidx/media3/transformer/ParameterizedInputSequenceExportTest.java index d17394f102..8f6e21d38f 100644 --- a/libraries/transformer/src/androidTest/java/androidx/media3/transformer/ParameterizedInputSequenceExportTest.java +++ b/libraries/transformer/src/androidTest/java/androidx/media3/transformer/ParameterizedInputSequenceExportTest.java @@ -24,6 +24,7 @@ import static androidx.media3.transformer.ParameterizedAndroidTestUtil.assumeSeq import static com.google.common.truth.Truth.assertThat; import android.content.Context; +import android.util.Log; import androidx.media3.effect.Presentation; import androidx.media3.transformer.ParameterizedAndroidTestUtil.SdrImageItemConfig; import androidx.media3.transformer.ParameterizedAndroidTestUtil.SequenceConfig; @@ -47,6 +48,8 @@ import org.junit.runners.Parameterized.Parameters; /** Parameterized end-to-end test for exporting a {@link EditedMediaItemSequence}. */ @RunWith(Parameterized.class) public final class ParameterizedInputSequenceExportTest { + private static final String TAG = "ParameterizedTest"; + private static final SdrImageItemConfig PNG_ITEM = new SdrImageItemConfig(PNG_ASSET, /* frameCount= */ 34); private static final SdrImageItemConfig JPG_ITEM = @@ -64,7 +67,7 @@ public final class ParameterizedInputSequenceExportTest { /* audioProcessors= */ ImmutableList.of(), ImmutableList.of(Presentation.createForHeight(360)))); - @Parameters(name = "{0}") + @Parameters public static ImmutableList params() { return ImmutableList.of( new SequenceConfig(PNG_ITEM, PNG_ITEM), @@ -103,6 +106,7 @@ public final class ParameterizedInputSequenceExportTest { public void export_completesWithCorrectFrameCount() throws Exception { Context context = ApplicationProvider.getApplicationContext(); String testId = testName.getMethodName(); + Log.w(TAG, sequence.toString()); assumeSequenceFormatsSupported(context, testId, sequence); Transformer transformer = new Transformer.Builder(context) @@ -123,6 +127,7 @@ public final class ParameterizedInputSequenceExportTest { public void export_withCompositionEffect_completesWithCorrectFrameCount() throws Exception { Context context = ApplicationProvider.getApplicationContext(); String testId = testName.getMethodName(); + Log.w(TAG, sequence.toString()); assumeSequenceFormatsSupported(context, testId, sequence); Transformer transformer = new Transformer.Builder(context)