From 9baa6f6be54716271505fa159854afb457977e3c Mon Sep 17 00:00:00 2001 From: tofunmi Date: Fri, 5 May 2023 17:31:17 +0000 Subject: [PATCH] Fix operations order in RenderingTest For DefaultVideoFrameProcessorVideoFrameRenderingTest: `registerInputStream` sets the textureManager, so reordering makes sure the textureManager is set before you set the frame info. This is important for texture input, where the frame info provides the width and height. PiperOrigin-RevId: 529753404 --- .../DefaultVideoFrameProcessorVideoFrameRenderingTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libraries/effect/src/androidTest/java/androidx/media3/effect/DefaultVideoFrameProcessorVideoFrameRenderingTest.java b/libraries/effect/src/androidTest/java/androidx/media3/effect/DefaultVideoFrameProcessorVideoFrameRenderingTest.java index 3aabdfe8be..ee7efd4715 100644 --- a/libraries/effect/src/androidTest/java/androidx/media3/effect/DefaultVideoFrameProcessorVideoFrameRenderingTest.java +++ b/libraries/effect/src/androidTest/java/androidx/media3/effect/DefaultVideoFrameProcessorVideoFrameRenderingTest.java @@ -345,11 +345,11 @@ public final class DefaultVideoFrameProcessorVideoFrameRenderingTest { .submit( () -> { blankFrameProducer.configureGlObjects(); - checkNotNull(defaultVideoFrameProcessor) - .setInputFrameInfo(new FrameInfo.Builder(WIDTH, HEIGHT).build()); // A frame needs to be registered despite not queuing any external input to ensure // that the video frame processor knows about the stream offset. - defaultVideoFrameProcessor.registerInputStream(INPUT_TYPE_SURFACE); + checkNotNull(defaultVideoFrameProcessor).registerInputStream(INPUT_TYPE_SURFACE); + defaultVideoFrameProcessor.setInputFrameInfo( + new FrameInfo.Builder(WIDTH, HEIGHT).build()); defaultVideoFrameProcessor.registerInputFrame(); blankFrameProducer.produceBlankFramesAndQueueEndOfStream(inputPresentationTimesUs); defaultVideoFrameProcessor.signalEndOfInput();