loliball/media
1
0
Fork 0
mirror of https://github.com/androidx/media.git synced 2025-04-30 06:46:50 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add context as a parameter to shouldStartForegroundService

Browse Source 
Issue: androidx/media#1887
PiperOrigin-RevId: 697650546
This commit is contained in:
bachinger 2024-11-18 09:12:44 -08:00 committed by Copybara-Service
parent fff6e2e169
commit 9ae136becb
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
RELEASENOTES.md
View File

@ -335,6 +335,9 @@ This release includes the following changes since the
* Improve interoperability behavior, so that a Media3 browser that is
connected to a legacy `MediaBrowserService` doesn't request the children
of a `parentId` twice when subscribing to a parent.
* Add 'Context' as a parameter to
'MediaButtonReceiver.shouldStartForegroundService`
([#1887](https://github.com/androidx/media/issues/1887)).
* UI:
* Make the stretched/cropped video in
`PlayerView`-in-Compose-`AndroidView` workaround opt-in, due to issues

6
libraries/session/src/main/java/androidx/media3/session/MediaButtonReceiver.java
View File

@ -148,7 +148,7 @@ public class MediaButtonReceiver extends BroadcastReceiver {
ComponentName mediaButtonServiceComponentName = getServiceComponentByAction(context, action);
if (mediaButtonServiceComponentName != null) {
intent.setComponent(mediaButtonServiceComponentName);
if (!shouldStartForegroundService(intent)) {
if (!shouldStartForegroundService(context, intent)) {
Log.i(
TAG,
"onReceive(Intent) does not start the media button event target service into the"
@ -186,13 +186,15 @@ public class MediaButtonReceiver extends BroadcastReceiver {
* playback to get into the foreground or the system will crash the service with a {@code
* ForegroundServiceDidNotStartInTimeException} or an {@link IllegalStateException}.
*
* @param context The {@link Context} that {@linkplain #onReceive(Context, Intent) was received by
* the media button event receiver}.
* @param intent The intent that {@linkplain #onReceive(Context, Intent) was received by the media
* button event receiver}.
* @return true if the service should be {@linkplain ContextCompat#startForegroundService(Context,
* Intent) started as a foreground service}. If false is returned the service is not started
* and the receiver call is a no-op.
*/
protected boolean shouldStartForegroundService(Intent intent) {
protected boolean shouldStartForegroundService(Context context, Intent intent) {
return true;
}