loliball/media
1
0
Fork 0
mirror of https://github.com/androidx/media.git synced 2025-04-30 06:46:50 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Delete deprecated zero-arg DefaultBandwidthMeter constructor

Browse Source 
Use `DefaultBandwidthMeter.Builder` instead.

#minor-release

PiperOrigin-RevId: 532069549
This commit is contained in:
ibaker 2023-05-15 12:33:13 +01:00 committed by Ian Baker
parent 6dfb387117
commit 8f29a5eba9
3 changed files with 6 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
RELEASENOTES.md
View File

@ -11,6 +11,8 @@
* Remove two deprecated `SimpleCache` constructors, use a non-deprecated * Remove two deprecated `SimpleCache` constructors, use a non-deprecated
constructor that takes a `DatabaseProvider` instead for better constructor that takes a `DatabaseProvider` instead for better
performance. performance.
* Remove `DefaultBandwidthMeter` constructor, use
`DefaultBandwidthMeter.Builder` instead.
### 1.1.0-alpha01 (2023-05-10) ### 1.1.0-alpha01 (2023-05-10)

13
libraries/exoplayer/src/main/java/androidx/media3/exoplayer/upstream/DefaultBandwidthMeter.java
View File

@ -297,19 +297,6 @@ public final class DefaultBandwidthMeter implements BandwidthMeter, TransferList
private boolean networkTypeOverrideSet; private boolean networkTypeOverrideSet;
private @C.NetworkType int networkTypeOverride; private @C.NetworkType int networkTypeOverride;
/**
* @deprecated Use {@link Builder} instead.
*/
@Deprecated
public DefaultBandwidthMeter() {
this(
/* context= */ null,
/* initialBitrateEstimates= */ ImmutableMap.of(),
DEFAULT_SLIDING_WINDOW_MAX_WEIGHT,
Clock.DEFAULT,
/* resetOnNetworkTypeChange= */ false);
}
private DefaultBandwidthMeter( private DefaultBandwidthMeter(
@Nullable Context context, @Nullable Context context,
Map<Integer, Long> initialBitrateEstimates, Map<Integer, Long> initialBitrateEstimates,

14
libraries/exoplayer/src/test/java/androidx/media3/exoplayer/upstream/DefaultBandwidthMeterTest.java
View File

@ -688,19 +688,13 @@ public final class DefaultBandwidthMeterTest {
} }
@Test @Test
@SuppressWarnings("deprecation")
public void defaultInitialBitrateEstimate_withoutContext_isReasonable() { public void defaultInitialBitrateEstimate_withoutContext_isReasonable() {
DefaultBandwidthMeter bandwidthMeterWithBuilder = DefaultBandwidthMeter bandwidthMeter =
new DefaultBandwidthMeter.Builder(/* context= */ null).build(); new DefaultBandwidthMeter.Builder(/* context= */ null).build();
long initialEstimateWithBuilder = bandwidthMeterWithBuilder.getBitrateEstimate(); long initialEstimate = bandwidthMeter.getBitrateEstimate();
DefaultBandwidthMeter bandwidthMeterWithoutBuilder = new DefaultBandwidthMeter(); assertThat(initialEstimate).isGreaterThan(100_000L);
long initialEstimateWithoutBuilder = bandwidthMeterWithoutBuilder.getBitrateEstimate(); assertThat(initialEstimate).isLessThan(50_000_000L);
assertThat(initialEstimateWithBuilder).isGreaterThan(100_000L);
assertThat(initialEstimateWithBuilder).isLessThan(50_000_000L);
assertThat(initialEstimateWithoutBuilder).isGreaterThan(100_000L);
assertThat(initialEstimateWithoutBuilder).isLessThan(50_000_000L);
} }
private void setActiveNetworkInfo(NetworkInfo networkInfo) { private void setActiveNetworkInfo(NetworkInfo networkInfo) {