From 85e449cd8780b0c3012bfdbab19ea35fae2ee961 Mon Sep 17 00:00:00 2001 From: ibaker Date: Wed, 26 Apr 2023 17:35:52 +0100 Subject: [PATCH] Downgrade back to Robolectric 4.8.1 This partially reverts https://github.com/androidx/media/commit/889f435a49eff9dc9fb516bd0bee85c1ca7a3f7d because our tests fail with 4.10 with an error like: ``` ShadowActivityThread.reset: ActivityThread not set java.lang.NullPointerException: ShadowActivityThread.reset: ActivityThread not set at java.base/java.util.Objects.requireNonNull(Objects.java:246) at org.robolectric.shadows.ShadowActivityThread.reset(ShadowActivityThread.java:284) at org.robolectric.Shadows.reset(Shadows.java:2665) at org.robolectric.android.internal.AndroidTestEnvironment.resetState(AndroidTestEnvironment.java:657) at org.robolectric.RobolectricTestRunner.lambda$finallyAfterTest$0(RobolectricTestRunner.java:370) at org.robolectric.util.PerfStatsCollector.measure(PerfStatsCollector.java:86) at org.robolectric.RobolectricTestRunner.finallyAfterTest(RobolectricTestRunner.java:368) at org.robolectric.internal.SandboxTestRunner$2.lambda$evaluate$2(SandboxTestRunner.java:298) at org.robolectric.internal.bytecode.Sandbox.lambda$runOnMainThread$0(Sandbox.java:99) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630) at java.base/java.lang.Thread.run(Thread.java:830) ``` It looks like the code throwing this exception is new in Robolectric 4.10: https://github.com/robolectric/robolectric/commit/65654a76ce6f166301ab1efb2047bab1998f8949 PiperOrigin-RevId: 527290033 --- constants.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/constants.gradle b/constants.gradle index 32717c3562..6a949ce11f 100644 --- a/constants.gradle +++ b/constants.gradle @@ -29,7 +29,7 @@ project.ext { // https://cs.android.com/android/platform/superproject/+/master:external/guava/METADATA guavaVersion = '31.1-android' mockitoVersion = '3.12.4' - robolectricVersion = '4.10' + robolectricVersion = '4.8.1' // Keep this in sync with Google's internal Checker Framework version. checkerframeworkVersion = '3.13.0' checkerframeworkCompatVersion = '2.5.5'