From 82bed391409690a208149f9331e24c6416487a0f Mon Sep 17 00:00:00 2001 From: Olivier Jouvenaux Date: Fri, 3 Jan 2025 10:54:38 +0100 Subject: [PATCH] Add unit tests for TTML region attrs in style, chained styles UT --- .../androidx/media3/extractor/text/ttml/TtmlParserTest.java | 5 +++++ .../media/ttml/inherit_region_attributes_from_style.xml | 3 +++ 2 files changed, 8 insertions(+) diff --git a/libraries/extractor/src/test/java/androidx/media3/extractor/text/ttml/TtmlParserTest.java b/libraries/extractor/src/test/java/androidx/media3/extractor/text/ttml/TtmlParserTest.java index 09526c5376..821ce20e9b 100644 --- a/libraries/extractor/src/test/java/androidx/media3/extractor/text/ttml/TtmlParserTest.java +++ b/libraries/extractor/src/test/java/androidx/media3/extractor/text/ttml/TtmlParserTest.java @@ -1107,6 +1107,11 @@ public final class TtmlParserTest { assertThat(secondCue.position).isEqualTo(30f / 100f); assertThat(secondCue.line).isEqualTo(30f / 100f); assertThat(secondCue.size).isEqualTo(40f / 100f); + + Cue thirdCue = Iterables.getOnlyElement(allCues.get(2).cues); + assertThat(thirdCue.position).isEqualTo(30f / 100f); + assertThat(thirdCue.line).isEqualTo(30f / 100f); + assertThat(thirdCue.size).isEqualTo(20f / 100f); } private static Spanned getOnlyCueTextAtIndex(List allCues, int index) { diff --git a/libraries/test_data/src/test/assets/media/ttml/inherit_region_attributes_from_style.xml b/libraries/test_data/src/test/assets/media/ttml/inherit_region_attributes_from_style.xml index 56b1d3c189..6f06538ae7 100644 --- a/libraries/test_data/src/test/assets/media/ttml/inherit_region_attributes_from_style.xml +++ b/libraries/test_data/src/test/assets/media/ttml/inherit_region_attributes_from_style.xml @@ -4,16 +4,19 @@