From 813973bb580cd4cab456c71861bd409cab4e1215 Mon Sep 17 00:00:00 2001 From: bachinger Date: Wed, 12 Feb 2025 03:21:57 -0800 Subject: [PATCH] Explicitly test custom extra entries for legacy conversions Issue: androidx/media#2127 PiperOrigin-RevId: 725984132 --- .../androidx/media3/session/LegacyConversionsTest.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/libraries/session/src/test/java/androidx/media3/session/LegacyConversionsTest.java b/libraries/session/src/test/java/androidx/media3/session/LegacyConversionsTest.java index bfac5680a2..931a23edcc 100644 --- a/libraries/session/src/test/java/androidx/media3/session/LegacyConversionsTest.java +++ b/libraries/session/src/test/java/androidx/media3/session/LegacyConversionsTest.java @@ -16,7 +16,9 @@ package androidx.media3.session; import static androidx.media3.session.MediaConstants.EXTRAS_KEY_COMMAND_BUTTON_ICON_COMPAT; +import static androidx.media3.session.MediaConstants.EXTRAS_KEY_COMPLETION_STATUS; import static androidx.media3.session.MediaConstants.EXTRAS_KEY_MEDIA_TYPE_COMPAT; +import static androidx.media3.session.MediaConstants.EXTRAS_VALUE_COMPLETION_STATUS_PARTIALLY_PLAYED; import static androidx.media3.session.MediaConstants.EXTRA_KEY_ROOT_CHILDREN_BROWSABLE_ONLY; import static androidx.media3.session.legacy.MediaBrowserCompat.MediaItem.FLAG_BROWSABLE; import static androidx.media3.session.legacy.MediaBrowserCompat.MediaItem.FLAG_PLAYABLE; @@ -150,6 +152,8 @@ public final class LegacyConversionsTest { @Test public void convertToMediaDescriptionCompat_setsExpectedValues() { + Bundle extras = new Bundle(); + extras.putInt(EXTRAS_KEY_COMPLETION_STATUS, EXTRAS_VALUE_COMPLETION_STATUS_PARTIALLY_PLAYED); MediaMetadata metadata = new MediaMetadata.Builder() .setTitle("testTitle") @@ -158,6 +162,7 @@ public final class LegacyConversionsTest { .setWriter("testWriter") .setMediaType(MediaMetadata.MEDIA_TYPE_MUSIC) .setDurationMs(10_000L) + .setExtras(extras) .build(); MediaItem mediaItem = new MediaItem.Builder().setMediaId("testId").setMediaMetadata(metadata).build(); @@ -171,6 +176,8 @@ public final class LegacyConversionsTest { assertThat(descriptionCompat.getDescription().toString()).isEqualTo("testAlbumTitle"); assertThat(descriptionCompat.getExtras().getLong(EXTRAS_KEY_MEDIA_TYPE_COMPAT)) .isEqualTo(MediaMetadata.MEDIA_TYPE_MUSIC); + assertThat(descriptionCompat.getExtras().getInt(EXTRAS_KEY_COMPLETION_STATUS)) + .isEqualTo(EXTRAS_VALUE_COMPLETION_STATUS_PARTIALLY_PLAYED); } @Test