loliball/media
1
0
Fork 0
mirror of https://github.com/androidx/media.git synced 2025-04-30 06:46:50 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Do not dump buffers not fully consumed repeatedly in CapturingAudioSink

Browse Source 
#cherrypick

PiperOrigin-RevId: 736495022
This commit is contained in:
tianyifeng 2025-03-13 07:16:55 -07:00 committed by Copybara-Service
parent 4991e623c9
commit 6edb687aef
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libraries/test_utils/src/main/java/androidx/media3/test/utils/CapturingAudioSink.java
View File

@ -43,6 +43,7 @@ public final class CapturingAudioSink extends ForwardingAudioSink implements Dum
private int bufferCount;
private long lastPresentationTimeUs;
@Nullable private ByteBuffer currentBuffer;
/** Creates the capturing audio sink. */
public static CapturingAudioSink create() {
@ -86,12 +87,19 @@ public final class CapturingAudioSink extends ForwardingAudioSink implements Dum
ByteBuffer buffer, long presentationTimeUs, int encodedAccessUnitCount)
throws InitializationException, WriteException {
lastPresentationTimeUs = presentationTimeUs;
if (!buffer.hasRemaining()) {
// The handleBuffer is called repeatedly with the same buffer until it's been fully consumed by
// the sink. We only want to dump each buffer once.
if (buffer != currentBuffer && !buffer.hasRemaining()) {
// Empty buffers are not processed any further and need to be intercepted here.
// TODO: b/174737370 - Output audio bytes in Robolectric to avoid this situation.
interceptedData.add(new DumpableBuffer(bufferCount++, buffer, lastPresentationTimeUs));
currentBuffer = buffer;
}
return super.handleBuffer(buffer, presentationTimeUs, encodedAccessUnitCount);
boolean fullyBuffered = super.handleBuffer(buffer, presentationTimeUs, encodedAccessUnitCount);
if (fullyBuffered) {
currentBuffer = null;
}
return fullyBuffered;
}
@Override