loliball/media
1
0
Fork 0
mirror of https://github.com/androidx/media.git synced 2025-04-29 22:36:54 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tweak the parameter name in Util.shouldShowPlayButton

Browse Source 
The previous name sounds a bit like it refers to the action of
'playing', rather than which button is shown (which is kind of the
opposite!).

PiperOrigin-RevId: 743908736
This commit is contained in:
ibaker 2025-04-04 05:39:13 -07:00 committed by Copybara-Service
parent 72bb474604
commit 6c4c4bdea4
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libraries/common/src/main/java/androidx/media3/common/util/Util.java
View File

@ -3689,7 +3689,7 @@ public final class Util {
*/ */
@EnsuresNonNullIf(result = false, expression = "#1") @EnsuresNonNullIf(result = false, expression = "#1")
public static boolean shouldShowPlayButton(@Nullable Player player) { public static boolean shouldShowPlayButton(@Nullable Player player) {
return shouldShowPlayButton(player, /* playIfSuppressed= */ true); return shouldShowPlayButton(player, /* shouldShowPlayIfSuppressed= */ true);
} }
/** /**
@ -3700,17 +3700,18 @@ public final class Util {
* #handlePauseButtonAction} to handle the interaction with the play or pause button UI element. * #handlePauseButtonAction} to handle the interaction with the play or pause button UI element.
* *
* @param player The {@link Player}. May be {@code null}. * @param player The {@link Player}. May be {@code null}.
* @param playIfSuppressed Whether to show a play button if playback is {@linkplain * @param shouldShowPlayIfSuppressed Whether to show a play button if playback is {@linkplain
* Player#getPlaybackSuppressionReason() suppressed}. * Player#getPlaybackSuppressionReason() suppressed}.
*/ */
@UnstableApi @UnstableApi
@EnsuresNonNullIf(result = false, expression = "#1") @EnsuresNonNullIf(result = false, expression = "#1")
public static boolean shouldShowPlayButton(@Nullable Player player, boolean playIfSuppressed) { public static boolean shouldShowPlayButton(
@Nullable Player player, boolean shouldShowPlayIfSuppressed) {
return player == null return player == null
|| !player.getPlayWhenReady() || !player.getPlayWhenReady()
|| player.getPlaybackState() == Player.STATE_IDLE || player.getPlaybackState() == Player.STATE_IDLE
|| player.getPlaybackState() == Player.STATE_ENDED || player.getPlaybackState() == Player.STATE_ENDED
|| (playIfSuppressed || (shouldShowPlayIfSuppressed
&& player.getPlaybackSuppressionReason() != Player.PLAYBACK_SUPPRESSION_REASON_NONE); && player.getPlaybackSuppressionReason() != Player.PLAYBACK_SUPPRESSION_REASON_NONE);
} }