From 69884e764ef8c3dc892280d9371ea1d3cf24f0ab Mon Sep 17 00:00:00 2001
From: tonihei <tonihei@google.com>
Date: Wed, 15 Nov 2023 02:54:31 -0800
Subject: [PATCH] Workaround layout problems with Material Design

In some contexts (e.g. BottomSheetDialogFrament), Material Design
themes will override the default of singleLine=false to true. This
causes layout problems because the forward/rewind buttons are no
longer visible with singleLine=true.

This problem can be avoided by explicitly requesting the default
value of false in our layout files.

Issue: androidx/media#511

#minor-release

PiperOrigin-RevId: 582604131
(cherry picked from commit 310e2edccac75b1ed30eb69520224cb48d1cc190)
---
 RELEASENOTES.md                                               | 3 +++
 .../main/res/layout-v23/exo_player_control_ffwd_button.xml    | 4 ++++
 .../main/res/layout-v23/exo_player_control_rewind_button.xml  | 4 ++++
 .../ui/src/main/res/layout/exo_player_control_ffwd_button.xml | 4 ++++
 .../src/main/res/layout/exo_player_control_rewind_button.xml  | 4 ++++
 5 files changed, 19 insertions(+)

diff --git a/RELEASENOTES.md b/RELEASENOTES.md
index 15b43636e7..04ab268ffa 100644
--- a/RELEASENOTES.md
+++ b/RELEASENOTES.md
@@ -24,6 +24,9 @@
         `MediaMetadata.extras`
         ([#756](https://github.com/androidx/media/issues/756)).
 *   UI:
+    *   Fix issue where forward and rewind buttons are not visible when used
+        with Material Design in a BottomSheetDialogFragment
+        ([#511](https://github.com/androidx/media/issues/511)).
 *   Downloads:
 *   OkHttp Extension:
 *   Cronet Extension:
diff --git a/libraries/ui/src/main/res/layout-v23/exo_player_control_ffwd_button.xml b/libraries/ui/src/main/res/layout-v23/exo_player_control_ffwd_button.xml
index 18166f71f6..7a667e1b61 100644
--- a/libraries/ui/src/main/res/layout-v23/exo_player_control_ffwd_button.xml
+++ b/libraries/ui/src/main/res/layout-v23/exo_player_control_ffwd_button.xml
@@ -15,6 +15,10 @@
 -->
 <merge xmlns:android="http://schemas.android.com/apk/res/android">
 
+  <!-- Override of singleLine needed to avoid layout bugs with Material Design.
+       See https://github.com/androidx/media/issues/511.
+  -->
   <Button android:id="@+id/exo_ffwd_with_amount"
+      android:singleLine="false"
       style="@style/ExoStyledControls.Button.Center.FfwdWithAmount"/>
 </merge>
diff --git a/libraries/ui/src/main/res/layout-v23/exo_player_control_rewind_button.xml b/libraries/ui/src/main/res/layout-v23/exo_player_control_rewind_button.xml
index cbc507cc99..c659aa8ff1 100644
--- a/libraries/ui/src/main/res/layout-v23/exo_player_control_rewind_button.xml
+++ b/libraries/ui/src/main/res/layout-v23/exo_player_control_rewind_button.xml
@@ -15,6 +15,10 @@
 -->
 <merge xmlns:android="http://schemas.android.com/apk/res/android">
 
+  <!-- Override of singleLine needed to avoid layout bugs with Material Design.
+       See https://github.com/androidx/media/issues/511.
+  -->
   <Button android:id="@+id/exo_rew_with_amount"
+      android:singleLine="false"
       style="@style/ExoStyledControls.Button.Center.RewWithAmount"/>
 </merge>
diff --git a/libraries/ui/src/main/res/layout/exo_player_control_ffwd_button.xml b/libraries/ui/src/main/res/layout/exo_player_control_ffwd_button.xml
index bf4a0f94f0..4061b44cbb 100644
--- a/libraries/ui/src/main/res/layout/exo_player_control_ffwd_button.xml
+++ b/libraries/ui/src/main/res/layout/exo_player_control_ffwd_button.xml
@@ -22,10 +22,14 @@
       android:addStatesFromChildren="true"
       style="@style/ExoStyledControls.Button.Center">
     <!-- View's don't have foreground until API 23 so we have to nest in a parent. -->
+    <!-- Override of singleLine needed to avoid layout bugs with Material Design.
+         See https://github.com/androidx/media/issues/511.
+    -->
     <Button android:id="@id/exo_ffwd_with_amount"
         android:background="@drawable/exo_styled_controls_fastforward"
         android:layout_marginLeft="0dp"
         android:layout_marginRight="0dp"
+        android:singleLine="false"
         style="@style/ExoStyledControls.Button.Center.FfwdWithAmount"/>
 
   </FrameLayout>
diff --git a/libraries/ui/src/main/res/layout/exo_player_control_rewind_button.xml b/libraries/ui/src/main/res/layout/exo_player_control_rewind_button.xml
index fb25854f56..53d6e15392 100644
--- a/libraries/ui/src/main/res/layout/exo_player_control_rewind_button.xml
+++ b/libraries/ui/src/main/res/layout/exo_player_control_rewind_button.xml
@@ -22,10 +22,14 @@
       android:addStatesFromChildren="true"
       style="@style/ExoStyledControls.Button.Center">
     <!-- View's don't have foreground until API 23 so we have to nest in a parent. -->
+    <!-- Override of singleLine needed to avoid layout bugs with Material Design.
+       See https://github.com/androidx/media/issues/511.
+    -->
     <Button android:id="@id/exo_rew_with_amount"
         android:background="@drawable/exo_styled_controls_rewind"
         android:layout_marginLeft="0dp"
         android:layout_marginRight="0dp"
+        android:singleLine="false"
         style="@style/ExoStyledControls.Button.Center.RewWithAmount"/>
 
   </FrameLayout>