loliball/media
1
0
Fork 0
mirror of https://github.com/androidx/media.git synced 2025-05-10 17:22:13 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove incorrect TODOs

Browse Source 
PiperOrigin-RevId: 352552961
This commit is contained in:
andrewlewis 2021-01-19 14:15:38 +00:00 committed by Oliver Woodman
parent dc1842efb9
commit 60f000c8b1
2 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
library/common/src/main/java/com/google/android/exoplayer2/util/Util.java
View File

@ -2045,8 +2045,6 @@ public final class Util {
/** Returns a data URI with the specified MIME type and data. */ /** Returns a data URI with the specified MIME type and data. */
public static Uri getDataUriForString(String mimeType, String data) { public static Uri getDataUriForString(String mimeType, String data) {
// TODO(internal: b/169937045): For now we don't pass the URL_SAFE flag as DataSchemeDataSource
// doesn't decode using it.
return Uri.parse( return Uri.parse(
"data:" + mimeType + ";base64," + Base64.encodeToString(data.getBytes(), Base64.NO_WRAP)); "data:" + mimeType + ";base64," + Base64.encodeToString(data.getBytes(), Base64.NO_WRAP));
} }

1
library/core/src/main/java/com/google/android/exoplayer2/upstream/DataSchemeDataSource.java
View File

@ -59,7 +59,6 @@ public final class DataSchemeDataSource extends BaseDataSource {
String dataString = uriParts[1]; String dataString = uriParts[1];
if (uriParts[0].contains(";base64")) { if (uriParts[0].contains(";base64")) {
try { try {
// TODO(internal: b/169937045): Consider passing Base64.URL_SAFE flag.
data = Base64.decode(dataString, /* flags= */ Base64.DEFAULT); data = Base64.decode(dataString, /* flags= */ Base64.DEFAULT);
} catch (IllegalArgumentException e) { } catch (IllegalArgumentException e) {
throw new ParserException("Error while parsing Base64 encoded string: " + dataString, e); throw new ParserException("Error while parsing Base64 encoded string: " + dataString, e);