From 60f000c8b1c07bff650b3fee257079bbba4f893e Mon Sep 17 00:00:00 2001 From: andrewlewis Date: Tue, 19 Jan 2021 14:15:38 +0000 Subject: [PATCH] Remove incorrect TODOs PiperOrigin-RevId: 352552961 --- .../src/main/java/com/google/android/exoplayer2/util/Util.java | 2 -- .../android/exoplayer2/upstream/DataSchemeDataSource.java | 1 - 2 files changed, 3 deletions(-) diff --git a/library/common/src/main/java/com/google/android/exoplayer2/util/Util.java b/library/common/src/main/java/com/google/android/exoplayer2/util/Util.java index c4af6bd2fc..ec342a71a5 100644 --- a/library/common/src/main/java/com/google/android/exoplayer2/util/Util.java +++ b/library/common/src/main/java/com/google/android/exoplayer2/util/Util.java @@ -2045,8 +2045,6 @@ public final class Util { /** Returns a data URI with the specified MIME type and data. */ public static Uri getDataUriForString(String mimeType, String data) { - // TODO(internal: b/169937045): For now we don't pass the URL_SAFE flag as DataSchemeDataSource - // doesn't decode using it. return Uri.parse( "data:" + mimeType + ";base64," + Base64.encodeToString(data.getBytes(), Base64.NO_WRAP)); } diff --git a/library/core/src/main/java/com/google/android/exoplayer2/upstream/DataSchemeDataSource.java b/library/core/src/main/java/com/google/android/exoplayer2/upstream/DataSchemeDataSource.java index 2c3670f52a..2b9cf00e47 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/upstream/DataSchemeDataSource.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/upstream/DataSchemeDataSource.java @@ -59,7 +59,6 @@ public final class DataSchemeDataSource extends BaseDataSource { String dataString = uriParts[1]; if (uriParts[0].contains(";base64")) { try { - // TODO(internal: b/169937045): Consider passing Base64.URL_SAFE flag. data = Base64.decode(dataString, /* flags= */ Base64.DEFAULT); } catch (IllegalArgumentException e) { throw new ParserException("Error while parsing Base64 encoded string: " + dataString, e);