From 60a68f8891f732e1944a9c605ed063cf8faf84d4 Mon Sep 17 00:00:00 2001 From: ibaker Date: Wed, 27 Oct 2021 15:10:30 +0100 Subject: [PATCH] Remove IntRange from Player.getMediaItemAt No other index-related methods in Player are annotated, it's considered obvious that these should be >=0. PiperOrigin-RevId: 405882756 --- .../common/src/main/java/androidx/media3/common/Player.java | 2 +- .../main/java/androidx/media3/session/MediaController.java | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/libraries/common/src/main/java/androidx/media3/common/Player.java b/libraries/common/src/main/java/androidx/media3/common/Player.java index a46eb3709f..34d2579a3f 100644 --- a/libraries/common/src/main/java/androidx/media3/common/Player.java +++ b/libraries/common/src/main/java/androidx/media3/common/Player.java @@ -2175,7 +2175,7 @@ public interface Player { int getMediaItemCount(); /** Returns the {@link MediaItem} at the given index. */ - MediaItem getMediaItemAt(@IntRange(from = 0) int index); + MediaItem getMediaItemAt(int index); /** * Returns the duration of the current content or ad in milliseconds, or {@link C#TIME_UNSET} if diff --git a/libraries/session/src/main/java/androidx/media3/session/MediaController.java b/libraries/session/src/main/java/androidx/media3/session/MediaController.java index b0fb127a49..abe16f9a6e 100644 --- a/libraries/session/src/main/java/androidx/media3/session/MediaController.java +++ b/libraries/session/src/main/java/androidx/media3/session/MediaController.java @@ -35,6 +35,7 @@ import android.view.SurfaceHolder; import android.view.SurfaceView; import android.view.TextureView; import androidx.annotation.FloatRange; +import androidx.annotation.IntRange; import androidx.annotation.Nullable; import androidx.annotation.VisibleForTesting; import androidx.media3.common.AudioAttributes; @@ -676,6 +677,7 @@ public class MediaController implements Player { } @Override + @IntRange(from = 0, to = 100) public int getBufferedPercentage() { verifyApplicationThread(); return isConnected() ? impl.getBufferedPercentage() : 0; @@ -1627,6 +1629,7 @@ public class MediaController implements Player { } @Override + @IntRange(from = 0) public int getDeviceVolume() { verifyApplicationThread(); if (!isConnected()) { @@ -1645,7 +1648,7 @@ public class MediaController implements Player { } @Override - public void setDeviceVolume(int volume) { + public void setDeviceVolume(@IntRange(from = 0) int volume) { verifyApplicationThread(); if (!isConnected()) { Log.w(TAG, "The controller is not connected. Ignoring setDeviceVolume().");