loliball/media
1
0
Fork 0
mirror of https://github.com/androidx/media.git synced 2025-05-07 07:30:22 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Allow pause if in offload mode after writing all buffers

Browse Source 
In offload mode, `AudioTrack#stop()` will put the track in `PLAYSTATE_STOPPING` rather than `PLAYSTATE_STOPPED`. The difference in state means that `AudioTrack` can be paused and played during this 'stopping' period.

Currently, if `AudioTrackPositionTracker#handleEndOfStream()` has been called then `DefaultAudioSink` in `pause()` won't call `AudioTrack#pause()`. `AudioTrack#pause()` should be called in this case if in offload mode.

#minor-release

PiperOrigin-RevId: 571335108
(cherry picked from commit ab42d64d6d5f1859f1c45aebfe26060978b864bd)
This commit is contained in:
michaelkatz 2023-10-06 07:43:11 -07:00 committed by oceanjules
parent da5a743175
commit 5d0d30a280
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libraries/exoplayer/src/main/java/androidx/media3/exoplayer/audio/DefaultAudioSink.java
View File

@ -1407,7 +1407,8 @@ public final class DefaultAudioSink implements AudioSink {
@Override @Override
public void pause() { public void pause() {
playing = false; playing = false;
if (isAudioTrackInitialized() && audioTrackPositionTracker.pause()) { if (isAudioTrackInitialized()
&& (audioTrackPositionTracker.pause() || isOffloadedPlayback(audioTrack))) {
audioTrack.pause(); audioTrack.pause();
} }
} }