loliball/media
1
0
Fork 0
mirror of https://github.com/androidx/media.git synced 2025-04-30 06:46:50 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Default RepeatMode for conversion is NONE/OFF

Browse Source 
Current behaviour causes an app to crash if it receives an unrecognized repeat mode send over the wire. In order to avoid the crash, a sensible default had to be chosen.

For `Player.RepeatMode`, it is `Player.REPEAT_MODE_OFF`, which is the same value we use as default when unbundling `PlayerInfo`.

For `PlaybackStateCompat.RepeatMode`, it is `PlaybackStateCompat.REPEAT_MODE_NONE`, which is what we use in the no-arg `LegacyPlayerInfo` constructor.

Issue: androidx/media#448

#minor-release

PiperOrigin-RevId: 540563792
This commit is contained in:
jbibik 2023-06-15 14:31:59 +01:00 committed by Marc Baechinger
parent 42915e9a58
commit 501da109ce
1 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
libraries/session/src/main/java/androidx/media3/session/MediaUtils.java
View File

@ -971,8 +971,12 @@ import java.util.concurrent.TimeoutException;
case PlaybackStateCompat.REPEAT_MODE_GROUP: case PlaybackStateCompat.REPEAT_MODE_GROUP:
return Player.REPEAT_MODE_ALL; return Player.REPEAT_MODE_ALL;
default: default:
throw new IllegalArgumentException( Log.w(
"Unrecognized PlaybackStateCompat.RepeatMode: " + playbackStateCompatRepeatMode); TAG,
"Unrecognized PlaybackStateCompat.RepeatMode: "
+ playbackStateCompatRepeatMode
+ " was converted to `Player.REPEAT_MODE_OFF`");
return Player.REPEAT_MODE_OFF;
} }
} }
@ -987,7 +991,12 @@ import java.util.concurrent.TimeoutException;
case Player.REPEAT_MODE_ALL: case Player.REPEAT_MODE_ALL:
return PlaybackStateCompat.REPEAT_MODE_ALL; return PlaybackStateCompat.REPEAT_MODE_ALL;
default: default:
throw new IllegalArgumentException("Unrecognized RepeatMode: " + repeatMode); Log.w(
TAG,
"Unrecognized RepeatMode: "
+ repeatMode
+ " was converted to `PlaybackStateCompat.REPEAT_MODE_NONE`");
return PlaybackStateCompat.REPEAT_MODE_NONE;
} }
} }
@ -1392,9 +1401,9 @@ import java.util.concurrent.TimeoutException;
* previousPlayerInfo} and taking into account the passed available commands. * previousPlayerInfo} and taking into account the passed available commands.
* *
* @param oldPlayerInfo The old {@link PlayerInfo}. * @param oldPlayerInfo The old {@link PlayerInfo}.
* @param oldBundlingExclusions The bundling exlusions in the old {@link PlayerInfo}. * @param oldBundlingExclusions The bundling exclusions in the old {@link PlayerInfo}.
* @param newPlayerInfo The new {@link PlayerInfo}. * @param newPlayerInfo The new {@link PlayerInfo}.
* @param newBundlingExclusions The bundling exlusions in the new {@link PlayerInfo}. * @param newBundlingExclusions The bundling exclusions in the new {@link PlayerInfo}.
* @param availablePlayerCommands The available commands to take into account when merging. * @param availablePlayerCommands The available commands to take into account when merging.
* @return A pair with the resulting {@link PlayerInfo} and {@link BundlingExclusions}. * @return A pair with the resulting {@link PlayerInfo} and {@link BundlingExclusions}.
*/ */