loliball/media
1
0
Fork 0
mirror of https://github.com/androidx/media.git synced 2025-04-29 22:36:54 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Only join video graph output in playlist mode.

Browse Source 
DefaultVideoSink.join() was called when join() was called on the
InputVideoSink. This makes sense in playlist mode but we shouldn't
join if the VideoGraph output is considered as a single clip.

This change is no-op. Indeed, for CompositionPlayer, the
allowedJoiningTimeMs is set to 0, so that join doesn't have any effect.

PiperOrigin-RevId: 750238085
This commit is contained in:
kimvde 2025-04-22 10:13:34 -07:00 committed by Copybara-Service
parent fe10ca2c9a
commit 4d68243158
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libraries/exoplayer/src/main/java/androidx/media3/exoplayer/video/PlaybackVideoGraphWrapper.java
View File

@ -668,6 +668,10 @@ public final class PlaybackVideoGraphWrapper implements VideoSinkProvider, Video
checkStateNotNull(handler).post(() -> pendingFlushCount--); checkStateNotNull(handler).post(() -> pendingFlushCount--);
} }
private void joinPlayback(boolean renderNextFrameImmediately) {
defaultVideoSink.join(renderNextFrameImmediately);
}
private void setVideoFrameMetadataListener( private void setVideoFrameMetadataListener(
VideoFrameMetadataListener videoFrameMetadataListener) { VideoFrameMetadataListener videoFrameMetadataListener) {
this.videoFrameMetadataListener = videoFrameMetadataListener; this.videoFrameMetadataListener = videoFrameMetadataListener;
@ -1023,7 +1027,9 @@ public final class PlaybackVideoGraphWrapper implements VideoSinkProvider, Video
@Override @Override
public void join(boolean renderNextFrameImmediately) { public void join(boolean renderNextFrameImmediately) {
defaultVideoSink.join(renderNextFrameImmediately); if (enablePlaylistMode) {
PlaybackVideoGraphWrapper.this.joinPlayback(renderNextFrameImmediately);
}
} }
@Override @Override