loliball/media
1
0
Fork 0
mirror of https://github.com/androidx/media.git synced 2025-04-30 06:46:50 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Call both old and new onLoadStarted methods in DefaultAnalyticsCollector

Browse Source
This commit is contained in:
Ian Baker 2024-10-23 14:29:19 +01:00
parent d3298391b2
commit 473a4a7680
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libraries/exoplayer/src/main/java/androidx/media3/exoplayer/analytics/AnalyticsListener.java
View File

@ -844,11 +844,8 @@ public interface AnalyticsListener {
default void onPlaylistMetadataChanged(EventTime eventTime, MediaMetadata playlistMetadata) {} default void onPlaylistMetadataChanged(EventTime eventTime, MediaMetadata playlistMetadata) {}
/** /**
* Called when a media source started loading data. * @deprecated Implement {@link #onLoadStarted(EventTime, LoadEventInfo, MediaLoadData, int)}
* * instead.
* @param eventTime The event time.
* @param loadEventInfo The {@link LoadEventInfo} defining the load event.
* @param mediaLoadData The {@link MediaLoadData} defining the data being loaded.
*/ */
@UnstableApi @UnstableApi
@Deprecated @Deprecated

6
libraries/exoplayer/src/main/java/androidx/media3/exoplayer/analytics/DefaultAnalyticsCollector.java
View File

@ -397,6 +397,8 @@ public class DefaultAnalyticsCollector implements AnalyticsCollector {
// MediaSourceEventListener implementation. // MediaSourceEventListener implementation.
// Deliberately calling deprecated listener method for backwards compatibility.
@SuppressWarnings("deprecation")
@Override @Override
public final void onLoadStarted( public final void onLoadStarted(
int windowIndex, int windowIndex,
@ -405,6 +407,10 @@ public class DefaultAnalyticsCollector implements AnalyticsCollector {
MediaLoadData mediaLoadData, MediaLoadData mediaLoadData,
int retryCount) { int retryCount) {
EventTime eventTime = generateMediaPeriodEventTime(windowIndex, mediaPeriodId); EventTime eventTime = generateMediaPeriodEventTime(windowIndex, mediaPeriodId);
sendEvent(
eventTime,
C.INDEX_UNSET,
listener -> listener.onLoadStarted(eventTime, loadEventInfo, mediaLoadData));
sendEvent( sendEvent(
eventTime, eventTime,
AnalyticsListener.EVENT_LOAD_STARTED, AnalyticsListener.EVENT_LOAD_STARTED,