From 3d2b33582543c1036e62514726db5b6031f196ed Mon Sep 17 00:00:00 2001 From: ibaker Date: Thu, 26 May 2022 14:16:53 +0000 Subject: [PATCH] Simplify `DefaultMediaSourceFactory` instantiation in a test There's no need to manually construct a 'default' DefaultDataSource.Factory instance, we can just pass the `Context` to `DefaultMediaSourceFactory` and let it construct the `DefaultDataSource.Factory` internally. PiperOrigin-RevId: 451155747 --- .../java/androidx/media3/exoplayer/ima/ImaPlaybackTest.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libraries/exoplayer_ima/src/androidTest/java/androidx/media3/exoplayer/ima/ImaPlaybackTest.java b/libraries/exoplayer_ima/src/androidTest/java/androidx/media3/exoplayer/ima/ImaPlaybackTest.java index 6eb3bd393b..cee2106100 100644 --- a/libraries/exoplayer_ima/src/androidTest/java/androidx/media3/exoplayer/ima/ImaPlaybackTest.java +++ b/libraries/exoplayer_ima/src/androidTest/java/androidx/media3/exoplayer/ima/ImaPlaybackTest.java @@ -30,9 +30,7 @@ import androidx.media3.common.Player.TimelineChangeReason; import androidx.media3.common.Timeline.Window; import androidx.media3.common.util.Assertions; import androidx.media3.common.util.Util; -import androidx.media3.datasource.DataSource; import androidx.media3.datasource.DataSpec; -import androidx.media3.datasource.DefaultDataSource; import androidx.media3.exoplayer.DecoderCounters; import androidx.media3.exoplayer.ExoPlayer; import androidx.media3.exoplayer.analytics.AnalyticsListener; @@ -235,14 +233,13 @@ public final class ImaPlaybackTest { protected MediaSource buildSource( HostActivity host, DrmSessionManager drmSessionManager, FrameLayout overlayFrameLayout) { Context context = host.getApplicationContext(); - DataSource.Factory dataSourceFactory = new DefaultDataSource.Factory(context); MediaSource contentMediaSource = new DefaultMediaSourceFactory(context).createMediaSource(MediaItem.fromUri(contentUri)); return new AdsMediaSource( contentMediaSource, adTagDataSpec, /* adsId= */ adTagDataSpec.uri, - new DefaultMediaSourceFactory(dataSourceFactory), + new DefaultMediaSourceFactory(context), Assertions.checkNotNull(imaAdsLoader), () -> overlayFrameLayout); }