From 33d9b78e21c2ac6f382695c9c834c013c05f38ad Mon Sep 17 00:00:00 2001 From: Colin Kho Date: Wed, 7 Aug 2024 16:49:57 -0700 Subject: [PATCH] Fix javadoc of onLoadStarted & remove error information as fields --- .../java/androidx/media3/exoplayer/upstream/Loader.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/upstream/Loader.java b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/upstream/Loader.java index 18fda8598d..9a0e8e0656 100644 --- a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/upstream/Loader.java +++ b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/upstream/Loader.java @@ -94,13 +94,11 @@ public final class Loader implements LoaderErrorThrower { * Called when a load has started for the first time or through a retry. * * @param loadable The loadable whose load has completed. - * @param elapsedRealtimeMs {@link SystemClock#elapsedRealtime} when the load ended. + * @param elapsedRealtimeMs {@link SystemClock#elapsedRealtime} when the load attempts to start. * @param loadDurationMs The duration in milliseconds of the load since {@link #startLoading} * was called. - * @param error The load error of the previous load attempt if this is a retry, otherwise null - * @param errorCount The number of errors this load has encountered thus far. */ - default void onLoadStarted(T loadable, long elapsedRealtimeMs, long loadDurationMs, @Nullable IOException error, int errorCount) {} + default void onLoadStarted(T loadable, long elapsedRealtimeMs, long loadDurationMs) {} /** * Called when a load has completed. @@ -545,7 +543,7 @@ public final class Loader implements LoaderErrorThrower { private void execute() { long nowMs = SystemClock.elapsedRealtime(); long durationMs = nowMs - startTimeMs; - Assertions.checkNotNull(this.callback).onLoadStarted(loadable, nowMs, durationMs, currentError, errorCount); + Assertions.checkNotNull(this.callback).onLoadStarted(loadable, nowMs, durationMs); currentError = null; downloadExecutor.execute(Assertions.checkNotNull(currentTask)); }