loliball/media
1
0
Fork 0
mirror of https://github.com/androidx/media.git synced 2025-04-30 06:46:50 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add thread names to the 'player accessed on wrong thread' message

Browse Source 
This will help app developers identify which thread is being used and
which is expected.

PiperOrigin-RevId: 370409697
This commit is contained in:
ibaker 2021-04-26 09:42:08 +01:00 committed by Andrew Lewis
parent 2a0b45ac77
commit 2b582b540a
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
library/core/src/main/java/com/google/android/exoplayer2/SimpleExoPlayer.java
View File

@ -588,9 +588,6 @@ public class SimpleExoPlayer extends BasePlayer
}
private static final String TAG = "SimpleExoPlayer";
private static final String WRONG_THREAD_ERROR_MESSAGE =
"Player is accessed on the wrong thread. See "
+ "https://exoplayer.dev/issues/player-accessed-on-wrong-thread";
protected final Renderer[] renderers;
@ -2014,13 +2011,18 @@ public class SimpleExoPlayer extends BasePlayer
// the app thread until the constructor finished executing.
constructorFinished.blockUninterruptible();
if (Looper.myLooper() != getApplicationLooper()) {
String message =
Util.formatInvariant(
"Player is accessed on the wrong thread.\n"
+ "Current thread: '%s'\n"
+ "Expected thread: '%s'\n"
+ "See https://exoplayer.dev/issues/player-accessed-on-wrong-thread",
Looper.myLooper().getThread().getName(),
getApplicationLooper().getThread().getName());
if (throwsWhenUsingWrongThread) {
throw new IllegalStateException(WRONG_THREAD_ERROR_MESSAGE);
throw new IllegalStateException(message);
}
Log.w(
TAG,
WRONG_THREAD_ERROR_MESSAGE,
hasNotifiedFullWrongThreadWarning ? null : new IllegalStateException());
Log.w(TAG, message, hasNotifiedFullWrongThreadWarning ? null : new IllegalStateException());
hasNotifiedFullWrongThreadWarning = true;
}
}