Improve EventLogger metadata logging

1. Fix indentation
2. Fix intention to only log one Metadata block

PiperOrigin-RevId: 434818209
This commit is contained in:
olly 2022-03-15 19:02:41 +00:00 committed by Ian Baker
parent 03c02b8b5d
commit 298e61398e

View File

@ -286,19 +286,19 @@ public class EventLogger implements AnalyticsListener {
} }
// TODO: Replace this with an override of onMediaMetadataChanged. // TODO: Replace this with an override of onMediaMetadataChanged.
// Log metadata for at most one of the selected tracks. // Log metadata for at most one of the selected tracks.
for (int groupIndex = 0; groupIndex < trackGroupInfos.size(); groupIndex++) { boolean loggedMetadata = false;
for (int groupIndex = 0; !loggedMetadata && groupIndex < trackGroupInfos.size(); groupIndex++) {
TracksInfo.TrackGroupInfo trackGroupInfo = trackGroupInfos.get(groupIndex); TracksInfo.TrackGroupInfo trackGroupInfo = trackGroupInfos.get(groupIndex);
TrackGroup trackGroup = trackGroupInfo.getTrackGroup(); TrackGroup trackGroup = trackGroupInfo.getTrackGroup();
for (int trackIndex = 0; trackIndex < trackGroup.length; trackIndex++) { for (int trackIndex = 0; !loggedMetadata && trackIndex < trackGroup.length; trackIndex++) {
if (!trackGroupInfo.isTrackSelected(trackIndex)) { if (trackGroupInfo.isTrackSelected(trackIndex)) {
continue;
}
@Nullable Metadata metadata = trackGroup.getFormat(trackIndex).metadata; @Nullable Metadata metadata = trackGroup.getFormat(trackIndex).metadata;
if (metadata != null) { if (metadata != null && metadata.length() > 0) {
logd(" Metadata ["); logd(" Metadata [");
printMetadata(metadata, " "); printMetadata(metadata, " ");
logd(" ]"); logd(" ]");
break; loggedMetadata = true;
}
} }
} }
} }