From 27d78e69d7a394cf8f5f739061d835e7c32091e2 Mon Sep 17 00:00:00 2001
From: claincly <claincly@google.com>
Date: Wed, 28 Feb 2024 10:28:34 -0800
Subject: [PATCH] Clarify `setVideoEffect()` javadoc

PiperOrigin-RevId: 611147963
---
 .../main/java/androidx/media3/exoplayer/ExoPlayer.java | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/ExoPlayer.java b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/ExoPlayer.java
index ff144f9174..5c79c3314d 100644
--- a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/ExoPlayer.java
+++ b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/ExoPlayer.java
@@ -1566,9 +1566,10 @@ public interface ExoPlayer extends Player {
    * frame.
    *
    * <p>If {@linkplain #setVideoSurface passing a surface to the player directly}, the output
-   * resolution needs to be signaled by passing a renderer message with type {@link
-   * Renderer#MSG_SET_VIDEO_OUTPUT_RESOLUTION} after calling this method. For {@link SurfaceView},
-   * {@link TextureView} and {@link SurfaceHolder} output this happens automatically.
+   * resolution needs to be signaled by passing a {@linkplain #createMessage(PlayerMessage.Target)
+   * message} to the {@linkplain Renderer video renderer} with type {@link
+   * Renderer#MSG_SET_VIDEO_OUTPUT_RESOLUTION} after calling this method. For {@link SurfaceView}
+   * and {@link SurfaceHolder} output this happens automatically.
    *
    * <p>The following limitations exist for using {@linkplain Effect video effects}:
    *
@@ -1579,7 +1580,8 @@ public interface ExoPlayer extends Player {
    *       version as the rest of the {@code androidx.media3} modules being used by the app.
    *   <li>This feature works only with the default {@link MediaCodecVideoRenderer} and not custom
    *       or extension {@linkplain Renderer video renderers}.
-   *   <li>This feature does not work with {@linkplain Effect effects} updating the timestamps.
+   *   <li>This feature does not work with {@linkplain Effect effects} that update the frame
+   *       timestamps.
    *   <li>This feature does not work with DRM-protected content.
    *   <li>This method should be called before calling {@link #prepare()}.
    * </ul>