From 24e1796c5095921df1da9ca9d2f6fa86d2f4bf8c Mon Sep 17 00:00:00 2001 From: huangdarwin Date: Tue, 26 Mar 2024 11:09:33 -0700 Subject: [PATCH] Effect: Improve setEnableColorTransfers javadoc. PiperOrigin-RevId: 619250163 --- .../androidx/media3/effect/DefaultVideoFrameProcessor.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/libraries/effect/src/main/java/androidx/media3/effect/DefaultVideoFrameProcessor.java b/libraries/effect/src/main/java/androidx/media3/effect/DefaultVideoFrameProcessor.java index 799cb3e3c5..8ee6205290 100644 --- a/libraries/effect/src/main/java/androidx/media3/effect/DefaultVideoFrameProcessor.java +++ b/libraries/effect/src/main/java/androidx/media3/effect/DefaultVideoFrameProcessor.java @@ -111,7 +111,14 @@ public final class DefaultVideoFrameProcessor implements VideoFrameProcessor { /** * Sets whether to transfer colors to an intermediate color space when applying effects. * + *

The default value is {@code true}. + * *

If the input or output is HDR, this must be {@code true}. + * + *

If all input and output content will be SDR, it's recommended to set this value to + * {@code false}. This is because 8-bit colors in SDR may result in color banding. + * + *

This doesn't currently work with overlay effects (ex. {@link TextureOverlay}). */ @CanIgnoreReturnValue public Builder setEnableColorTransfers(boolean enableColorTransfers) {