From 229aadc91bb625fec3fc5bcec8434e6efffc2cad Mon Sep 17 00:00:00 2001
From: dancho <dancho@google.com>
Date: Tue, 7 Jan 2025 08:31:02 -0800
Subject: [PATCH] Update javadoc for FLAG_READ_WITHIN_GOP_SAMPLE_DEPENDENCIES

Reflects that FLAG_READ_WITHIN_GOP_SAMPLE_DEPENDENCIES only parses
H.264 bitstream, and that H.265 parsing will be controlled with
another flag.

PiperOrigin-RevId: 712921990
---
 .../exoplayer/source/chunk/BundledChunkExtractor.java     | 4 ++--
 .../media3/extractor/mp4/FragmentedMp4Extractor.java      | 8 +-------
 .../java/androidx/media3/extractor/mp4/Mp4Extractor.java  | 8 +-------
 3 files changed, 4 insertions(+), 16 deletions(-)

diff --git a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/source/chunk/BundledChunkExtractor.java b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/source/chunk/BundledChunkExtractor.java
index 11c10140ea..5190eca4e9 100644
--- a/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/source/chunk/BundledChunkExtractor.java
+++ b/libraries/exoplayer/src/main/java/androidx/media3/exoplayer/source/chunk/BundledChunkExtractor.java
@@ -163,8 +163,8 @@ public final class BundledChunkExtractor implements ExtractorOutput, ChunkExtrac
     }
 
     /**
-     * Sets whether within GOP sample dependency information should be parsed as part of extraction.
-     * Defaults to {@code false}.
+     * Sets whether within GOP sample dependency information for {@linkplain MimeTypes#VIDEO_H264
+     * H.264} video should be parsed as part of extraction. Defaults to {@code false}.
      *
      * <p>Having access to additional sample dependency information can speed up seeking. See {@link
      * FragmentedMp4Extractor#FLAG_READ_WITHIN_GOP_SAMPLE_DEPENDENCIES}.
diff --git a/libraries/extractor/src/main/java/androidx/media3/extractor/mp4/FragmentedMp4Extractor.java b/libraries/extractor/src/main/java/androidx/media3/extractor/mp4/FragmentedMp4Extractor.java
index 3f8dd29b53..76f881551e 100644
--- a/libraries/extractor/src/main/java/androidx/media3/extractor/mp4/FragmentedMp4Extractor.java
+++ b/libraries/extractor/src/main/java/androidx/media3/extractor/mp4/FragmentedMp4Extractor.java
@@ -137,7 +137,7 @@ public class FragmentedMp4Extractor implements Extractor {
 
   /**
    * Flag to extract additional sample dependency information, and mark output buffers with {@link
-   * C#BUFFER_FLAG_NOT_DEPENDED_ON}.
+   * C#BUFFER_FLAG_NOT_DEPENDED_ON} for {@linkplain MimeTypes#VIDEO_H264 H.264} video.
    *
    * <p>This class always marks the samples at the start of each group of picture (GOP) with {@link
    * C#BUFFER_FLAG_KEY_FRAME}. Usually, key frames can be decoded independently, without depending
@@ -146,12 +146,6 @@ public class FragmentedMp4Extractor implements Extractor {
    * <p>Setting this flag enables elementary stream parsing to identify disposable samples that are
    * not depended on by other samples. Any disposable sample can be safely omitted, and the rest of
    * the track will remain valid.
-   *
-   * <p>Supported formats are:
-   *
-   * <ul>
-   *   <li>{@linkplain MimeTypes#VIDEO_H264 H.264}
-   * </ul>
    */
   public static final int FLAG_READ_WITHIN_GOP_SAMPLE_DEPENDENCIES = 1 << 6; // 64
 
diff --git a/libraries/extractor/src/main/java/androidx/media3/extractor/mp4/Mp4Extractor.java b/libraries/extractor/src/main/java/androidx/media3/extractor/mp4/Mp4Extractor.java
index b1ea9d81bf..5b51804b0e 100644
--- a/libraries/extractor/src/main/java/androidx/media3/extractor/mp4/Mp4Extractor.java
+++ b/libraries/extractor/src/main/java/androidx/media3/extractor/mp4/Mp4Extractor.java
@@ -138,7 +138,7 @@ public final class Mp4Extractor implements Extractor, SeekMap {
 
   /**
    * Flag to extract additional sample dependency information, and mark output buffers with {@link
-   * C#BUFFER_FLAG_NOT_DEPENDED_ON}.
+   * C#BUFFER_FLAG_NOT_DEPENDED_ON} for {@linkplain MimeTypes#VIDEO_H264 H.264} video.
    *
    * <p>This class always marks the samples at the start of each group of picture (GOP) with {@link
    * C#BUFFER_FLAG_KEY_FRAME}. Usually, key frames can be decoded independently, without depending
@@ -147,12 +147,6 @@ public final class Mp4Extractor implements Extractor, SeekMap {
    * <p>Setting this flag enables elementary stream parsing to identify disposable samples that are
    * not depended on by other samples. Any disposable sample can be safely omitted, and the rest of
    * the track will remain valid.
-   *
-   * <p>Supported formats are:
-   *
-   * <ul>
-   *   <li>{@linkplain MimeTypes#VIDEO_H264 H.264}
-   * </ul>
    */
   public static final int FLAG_READ_WITHIN_GOP_SAMPLE_DEPENDENCIES = 1 << 5;