From 184416adfce471a2fa98bccb941842588432ef31 Mon Sep 17 00:00:00 2001 From: shahddaghash Date: Fri, 21 Mar 2025 02:00:53 -0700 Subject: [PATCH] Prevent `metricsReporter.reportMetrics()` from throwing In general, metrics collection should not lead to Transformer thorwing and crashing the app. PiperOrigin-RevId: 739099456 (cherry picked from commit 3f5019b9088555e8bbbd492901c272ae47b5fb67) --- .../androidx/media3/transformer/EditingMetricsCollector.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libraries/transformer/src/main/java/androidx/media3/transformer/EditingMetricsCollector.java b/libraries/transformer/src/main/java/androidx/media3/transformer/EditingMetricsCollector.java index c9db736128..2dedc2760a 100644 --- a/libraries/transformer/src/main/java/androidx/media3/transformer/EditingMetricsCollector.java +++ b/libraries/transformer/src/main/java/androidx/media3/transformer/EditingMetricsCollector.java @@ -16,7 +16,6 @@ package androidx.media3.transformer; -import static androidx.media3.common.util.Assertions.checkState; import static androidx.media3.common.util.Util.usToMs; import android.content.Context; @@ -102,8 +101,7 @@ import java.util.List; @Override public void reportMetrics(EditingEndedEvent editingEndedEvent) { - checkState(!metricsReported, "Metrics have already been reported."); - if (editingSession != null) { + if (!metricsReported && editingSession != null) { editingSession.reportEditingEndedEvent(editingEndedEvent); metricsReported = true; }