From 0c6cfea048f9c0ee28390e34aa33ba0a6e8ae6eb Mon Sep 17 00:00:00 2001 From: rohks Date: Wed, 5 Jul 2023 15:04:50 +0100 Subject: [PATCH] Replace `BitArray.skipBytes()` with `BitArray.skipBits()` Based on the spec, ETSI TS 102 366 V1.4.1 Annex F, 6 bits should have skipped instead of 6 bytes. This correction was pointed out in Issue: androidx/media#474. PiperOrigin-RevId: 545658365 (cherry picked from commit 07d4e5986b06ef6e362fe00fb97187469f42bc25) --- .../src/main/java/androidx/media3/extractor/Ac3Util.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/extractor/src/main/java/androidx/media3/extractor/Ac3Util.java b/libraries/extractor/src/main/java/androidx/media3/extractor/Ac3Util.java index 439e76df4b..5d14801c9c 100644 --- a/libraries/extractor/src/main/java/androidx/media3/extractor/Ac3Util.java +++ b/libraries/extractor/src/main/java/androidx/media3/extractor/Ac3Util.java @@ -214,7 +214,7 @@ public final class Ac3Util { int numDepSub = dataBitArray.readBits(4); // num_dep_sub dataBitArray.skipBits(1); // numDepSub > 0 ? LFE2 : reserved if (numDepSub > 0) { - dataBitArray.skipBytes(6); // other channel configurations + dataBitArray.skipBits(6); // other channel configurations // Read Lrs/Rrs pair // TODO: Read other channel configuration if (dataBitArray.readBits(1) != 0) {