From 0bf21f2e204c489c0ad58bba0b3f43eb6fb4c688 Mon Sep 17 00:00:00 2001
From: ibaker <ibaker@google.com>
Date: Fri, 4 Feb 2022 16:13:07 +0000
Subject: [PATCH] Reshuffle the 'legacy' attrs.xml and drawables.xml files

Keep values related to LegacyPlayerView in attrs_legacy_player_view.xml
and put all values related to LegacyPlayerControlView back in their
original locations. We plan to remove LegacyPlayerView (and
attrs_legacy_player_view.xml) from media3, but will keep
LegacyPlayerControlView - so the separation of the XML files needs to
reflect this split.

#minor-release

PiperOrigin-RevId: 426406973
---
 libraries/ui/src/main/res/values/attrs.xml    | 27 ++++++++++++++++
 ...egacy.xml => attrs_legacy_player_view.xml} | 27 ----------------
 .../ui/src/main/res/values/drawables.xml      | 15 +++++++++
 .../src/main/res/values/drawables_legacy.xml  | 31 -------------------
 4 files changed, 42 insertions(+), 58 deletions(-)
 rename libraries/ui/src/main/res/values/{attrs_legacy.xml => attrs_legacy_player_view.xml} (67%)
 delete mode 100644 libraries/ui/src/main/res/values/drawables_legacy.xml

diff --git a/libraries/ui/src/main/res/values/attrs.xml b/libraries/ui/src/main/res/values/attrs.xml
index 9442753966..172b9acf0e 100644
--- a/libraries/ui/src/main/res/values/attrs.xml
+++ b/libraries/ui/src/main/res/values/attrs.xml
@@ -135,6 +135,33 @@
     <attr name="resize_mode"/>
   </declare-styleable>
 
+  <declare-styleable name="LegacyPlayerControlView">
+    <attr name="show_timeout"/>
+    <attr name="repeat_toggle_modes"/>
+    <attr name="show_rewind_button"/>
+    <attr name="show_fastforward_button"/>
+    <attr name="show_previous_button"/>
+    <attr name="show_next_button"/>
+    <attr name="show_shuffle_button"/>
+    <attr name="time_bar_min_update_interval"/>
+    <attr name="controller_layout_id"/>
+    <!-- DefaultTimeBar attributes -->
+    <attr name="bar_height"/>
+    <attr name="bar_gravity"/>
+    <attr name="touch_target_height"/>
+    <attr name="ad_marker_width"/>
+    <attr name="scrubber_enabled_size"/>
+    <attr name="scrubber_disabled_size"/>
+    <attr name="scrubber_dragged_size"/>
+    <attr name="scrubber_drawable"/>
+    <attr name="played_color"/>
+    <attr name="scrubber_color"/>
+    <attr name="buffered_color" />
+    <attr name="unplayed_color"/>
+    <attr name="ad_marker_color"/>
+    <attr name="played_ad_marker_color"/>
+  </declare-styleable>
+
   <declare-styleable name="StyledPlayerControlView">
     <attr name="show_timeout"/>
     <attr name="repeat_toggle_modes"/>
diff --git a/libraries/ui/src/main/res/values/attrs_legacy.xml b/libraries/ui/src/main/res/values/attrs_legacy_player_view.xml
similarity index 67%
rename from libraries/ui/src/main/res/values/attrs_legacy.xml
rename to libraries/ui/src/main/res/values/attrs_legacy_player_view.xml
index f042fa825f..47528a29de 100644
--- a/libraries/ui/src/main/res/values/attrs_legacy.xml
+++ b/libraries/ui/src/main/res/values/attrs_legacy_player_view.xml
@@ -51,31 +51,4 @@
     <attr name="played_ad_marker_color"/>
   </declare-styleable>
 
-  <declare-styleable name="LegacyPlayerControlView">
-    <attr name="show_timeout"/>
-    <attr name="repeat_toggle_modes"/>
-    <attr name="show_rewind_button"/>
-    <attr name="show_fastforward_button"/>
-    <attr name="show_previous_button"/>
-    <attr name="show_next_button"/>
-    <attr name="show_shuffle_button"/>
-    <attr name="time_bar_min_update_interval"/>
-    <attr name="controller_layout_id"/>
-    <!-- DefaultTimeBar attributes -->
-    <attr name="bar_height"/>
-    <attr name="bar_gravity"/>
-    <attr name="touch_target_height"/>
-    <attr name="ad_marker_width"/>
-    <attr name="scrubber_enabled_size"/>
-    <attr name="scrubber_disabled_size"/>
-    <attr name="scrubber_dragged_size"/>
-    <attr name="scrubber_drawable"/>
-    <attr name="played_color"/>
-    <attr name="scrubber_color"/>
-    <attr name="buffered_color" />
-    <attr name="unplayed_color"/>
-    <attr name="ad_marker_color"/>
-    <attr name="played_ad_marker_color"/>
-  </declare-styleable>
-
 </resources>
diff --git a/libraries/ui/src/main/res/values/drawables.xml b/libraries/ui/src/main/res/values/drawables.xml
index 9f3227b29e..6c65577a44 100644
--- a/libraries/ui/src/main/res/values/drawables.xml
+++ b/libraries/ui/src/main/res/values/drawables.xml
@@ -23,6 +23,21 @@
   <drawable name="exo_notification_stop">@drawable/exo_icon_stop</drawable>
   <drawable name="exo_notification_small_icon">@drawable/exo_icon_circular_play</drawable>
 
+  <drawable name="exo_legacy_controls_play">@drawable/exo_icon_play</drawable>
+  <drawable name="exo_legacy_controls_pause">@drawable/exo_icon_pause</drawable>
+  <drawable name="exo_legacy_controls_next">@drawable/exo_icon_next</drawable>
+  <drawable name="exo_legacy_controls_previous">@drawable/exo_icon_previous</drawable>
+  <drawable name="exo_legacy_controls_fastforward">@drawable/exo_icon_fastforward</drawable>
+  <drawable name="exo_legacy_controls_rewind">@drawable/exo_icon_rewind</drawable>
+  <drawable name="exo_legacy_controls_repeat_all">@drawable/exo_icon_repeat_all</drawable>
+  <drawable name="exo_legacy_controls_repeat_off">@drawable/exo_icon_repeat_off</drawable>
+  <drawable name="exo_legacy_controls_repeat_one">@drawable/exo_icon_repeat_one</drawable>
+  <drawable name="exo_legacy_controls_shuffle_off">@drawable/exo_icon_shuffle_off</drawable>
+  <drawable name="exo_legacy_controls_shuffle_on">@drawable/exo_icon_shuffle_on</drawable>
+  <drawable name="exo_legacy_controls_fullscreen_enter">@drawable/exo_icon_fullscreen_enter</drawable>
+  <drawable name="exo_legacy_controls_fullscreen_exit">@drawable/exo_icon_fullscreen_exit</drawable>
+  <drawable name="exo_legacy_controls_vr">@drawable/exo_icon_vr</drawable>
+
   <drawable name="exo_styled_controls_play">@drawable/exo_ic_play_circle_filled</drawable>
   <drawable name="exo_styled_controls_pause">@drawable/exo_ic_pause_circle_filled</drawable>
   <drawable name="exo_styled_controls_next">@drawable/exo_ic_skip_next</drawable>
diff --git a/libraries/ui/src/main/res/values/drawables_legacy.xml b/libraries/ui/src/main/res/values/drawables_legacy.xml
deleted file mode 100644
index 6460a974bc..0000000000
--- a/libraries/ui/src/main/res/values/drawables_legacy.xml
+++ /dev/null
@@ -1,31 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<!-- Copyright (C) 2019 The Android Open Source Project
-
-     Licensed under the Apache License, Version 2.0 (the "License");
-     you may not use this file except in compliance with the License.
-     You may obtain a copy of the License at
-
-          http://www.apache.org/licenses/LICENSE-2.0
-
-     Unless required by applicable law or agreed to in writing, software
-     distributed under the License is distributed on an "AS IS" BASIS,
-     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-     See the License for the specific language governing permissions and
-     limitations under the License.
--->
-<resources>
-  <drawable name="exo_legacy_controls_play">@drawable/exo_icon_play</drawable>
-  <drawable name="exo_legacy_controls_pause">@drawable/exo_icon_pause</drawable>
-  <drawable name="exo_legacy_controls_next">@drawable/exo_icon_next</drawable>
-  <drawable name="exo_legacy_controls_previous">@drawable/exo_icon_previous</drawable>
-  <drawable name="exo_legacy_controls_fastforward">@drawable/exo_icon_fastforward</drawable>
-  <drawable name="exo_legacy_controls_rewind">@drawable/exo_icon_rewind</drawable>
-  <drawable name="exo_legacy_controls_repeat_all">@drawable/exo_icon_repeat_all</drawable>
-  <drawable name="exo_legacy_controls_repeat_off">@drawable/exo_icon_repeat_off</drawable>
-  <drawable name="exo_legacy_controls_repeat_one">@drawable/exo_icon_repeat_one</drawable>
-  <drawable name="exo_legacy_controls_shuffle_off">@drawable/exo_icon_shuffle_off</drawable>
-  <drawable name="exo_legacy_controls_shuffle_on">@drawable/exo_icon_shuffle_on</drawable>
-  <drawable name="exo_legacy_controls_fullscreen_enter">@drawable/exo_icon_fullscreen_enter</drawable>
-  <drawable name="exo_legacy_controls_fullscreen_exit">@drawable/exo_icon_fullscreen_exit</drawable>
-  <drawable name="exo_legacy_controls_vr">@drawable/exo_icon_vr</drawable>
-</resources>