From 05a98a7b79e255b188ab7c0c40c02c2dfeb4f383 Mon Sep 17 00:00:00 2001 From: olly Date: Thu, 18 Oct 2018 04:01:53 -0700 Subject: [PATCH] Code shrinking doesn't like Class.super.defaultMethodName Just not doing it seems simplier and more obviously correct than suppressing the warnings in our proguard file. Issue: #4890 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=217675527 --- .../android/exoplayer2/upstream/DefaultDataSource.java | 5 ++--- .../android/exoplayer2/upstream/cache/CacheDataSource.java | 3 ++- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/library/core/src/main/java/com/google/android/exoplayer2/upstream/DefaultDataSource.java b/library/core/src/main/java/com/google/android/exoplayer2/upstream/DefaultDataSource.java index acb2c59e0c..6504562c58 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/upstream/DefaultDataSource.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/upstream/DefaultDataSource.java @@ -23,6 +23,7 @@ import com.google.android.exoplayer2.util.Log; import com.google.android.exoplayer2.util.Util; import java.io.IOException; import java.util.ArrayList; +import java.util.Collections; import java.util.List; import java.util.Map; @@ -261,9 +262,7 @@ public final class DefaultDataSource implements DataSource { @Override public Map> getResponseHeaders() { - return dataSource == null - ? DataSource.super.getResponseHeaders() - : dataSource.getResponseHeaders(); + return dataSource == null ? Collections.emptyMap() : dataSource.getResponseHeaders(); } @Override diff --git a/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/CacheDataSource.java b/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/CacheDataSource.java index 37bc0aca37..eaf72cf7fb 100644 --- a/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/CacheDataSource.java +++ b/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/CacheDataSource.java @@ -34,6 +34,7 @@ import java.io.InterruptedIOException; import java.lang.annotation.Documented; import java.lang.annotation.Retention; import java.lang.annotation.RetentionPolicy; +import java.util.Collections; import java.util.List; import java.util.Map; @@ -367,7 +368,7 @@ public final class CacheDataSource implements DataSource { // TODO: Implement. return isReadingFromUpstream() ? upstreamDataSource.getResponseHeaders() - : DataSource.super.getResponseHeaders(); + : Collections.emptyMap(); } @Override