From 040a45f3101c7b123e2b58bf77d18dd8ed8ddba6 Mon Sep 17 00:00:00 2001 From: kimvde Date: Mon, 13 Sep 2021 13:00:59 +0100 Subject: [PATCH] Remove deprecated getDefaultRequestProperties from HttpDataSource #exo-fixit PiperOrigin-RevId: 396329591 --- RELEASENOTES.md | 2 ++ .../exoplayer2/ext/cronet/CronetDataSource.java | 7 ------- .../exoplayer2/ext/okhttp/OkHttpDataSource.java | 7 ------- .../exoplayer2/upstream/DefaultHttpDataSource.java | 7 ------- .../android/exoplayer2/upstream/HttpDataSource.java | 11 ----------- 5 files changed, 2 insertions(+), 32 deletions(-) diff --git a/RELEASENOTES.md b/RELEASENOTES.md index 244f05ecab..fd02527b4d 100644 --- a/RELEASENOTES.md +++ b/RELEASENOTES.md @@ -78,6 +78,8 @@ * Remove `SingleSampleMediaSource.createMediaSource(Uri, Format, long)`. Use `SingleSampleMediaSource.createMediaSource(MediaItem.Subtitle, long)` instead. + * Remove `HttpDataSource.Factory.getDefaultRequestProperties`. Use + `HttpDataSource.Factory.setDefaultRequestProperties` instead. * Remove `GvrAudioProcessor` and the GVR extension, which has been deprecated since 2.11.0. * Cast extension: diff --git a/extensions/cronet/src/main/java/com/google/android/exoplayer2/ext/cronet/CronetDataSource.java b/extensions/cronet/src/main/java/com/google/android/exoplayer2/ext/cronet/CronetDataSource.java index 483df638b3..3b8b6916ce 100644 --- a/extensions/cronet/src/main/java/com/google/android/exoplayer2/ext/cronet/CronetDataSource.java +++ b/extensions/cronet/src/main/java/com/google/android/exoplayer2/ext/cronet/CronetDataSource.java @@ -140,13 +140,6 @@ public class CronetDataSource extends BaseDataSource implements HttpDataSource { readTimeoutMs = DEFAULT_READ_TIMEOUT_MILLIS; } - /** @deprecated Use {@link #setDefaultRequestProperties(Map)} instead. */ - @Deprecated - @Override - public final RequestProperties getDefaultRequestProperties() { - return defaultRequestProperties; - } - @Override public final Factory setDefaultRequestProperties(Map defaultRequestProperties) { this.defaultRequestProperties.clearAndSet(defaultRequestProperties); diff --git a/extensions/okhttp/src/main/java/com/google/android/exoplayer2/ext/okhttp/OkHttpDataSource.java b/extensions/okhttp/src/main/java/com/google/android/exoplayer2/ext/okhttp/OkHttpDataSource.java index 9d5d1cc5a0..a40fb95680 100644 --- a/extensions/okhttp/src/main/java/com/google/android/exoplayer2/ext/okhttp/OkHttpDataSource.java +++ b/extensions/okhttp/src/main/java/com/google/android/exoplayer2/ext/okhttp/OkHttpDataSource.java @@ -87,13 +87,6 @@ public class OkHttpDataSource extends BaseDataSource implements HttpDataSource { defaultRequestProperties = new RequestProperties(); } - /** @deprecated Use {@link #setDefaultRequestProperties(Map)} instead. */ - @Deprecated - @Override - public final RequestProperties getDefaultRequestProperties() { - return defaultRequestProperties; - } - @Override public final Factory setDefaultRequestProperties(Map defaultRequestProperties) { this.defaultRequestProperties.clearAndSet(defaultRequestProperties); diff --git a/library/common/src/main/java/com/google/android/exoplayer2/upstream/DefaultHttpDataSource.java b/library/common/src/main/java/com/google/android/exoplayer2/upstream/DefaultHttpDataSource.java index d2c6b5e993..bcd878fcbc 100644 --- a/library/common/src/main/java/com/google/android/exoplayer2/upstream/DefaultHttpDataSource.java +++ b/library/common/src/main/java/com/google/android/exoplayer2/upstream/DefaultHttpDataSource.java @@ -78,13 +78,6 @@ public class DefaultHttpDataSource extends BaseDataSource implements HttpDataSou readTimeoutMs = DEFAULT_READ_TIMEOUT_MILLIS; } - /** @deprecated Use {@link #setDefaultRequestProperties(Map)} instead. */ - @Deprecated - @Override - public final RequestProperties getDefaultRequestProperties() { - return defaultRequestProperties; - } - @Override public final Factory setDefaultRequestProperties(Map defaultRequestProperties) { this.defaultRequestProperties.clearAndSet(defaultRequestProperties); diff --git a/library/common/src/main/java/com/google/android/exoplayer2/upstream/HttpDataSource.java b/library/common/src/main/java/com/google/android/exoplayer2/upstream/HttpDataSource.java index 150d983348..e76e6f0414 100644 --- a/library/common/src/main/java/com/google/android/exoplayer2/upstream/HttpDataSource.java +++ b/library/common/src/main/java/com/google/android/exoplayer2/upstream/HttpDataSource.java @@ -42,10 +42,6 @@ public interface HttpDataSource extends DataSource { @Override HttpDataSource createDataSource(); - /** @deprecated Use {@link #setDefaultRequestProperties(Map)} instead. */ - @Deprecated - RequestProperties getDefaultRequestProperties(); - /** * Sets the default request headers for {@link HttpDataSource} instances created by the factory. * @@ -153,13 +149,6 @@ public interface HttpDataSource extends DataSource { return createDataSourceInternal(defaultRequestProperties); } - /** @deprecated Use {@link #setDefaultRequestProperties(Map)} instead. */ - @Deprecated - @Override - public final RequestProperties getDefaultRequestProperties() { - return defaultRequestProperties; - } - @Override public final Factory setDefaultRequestProperties(Map defaultRequestProperties) { this.defaultRequestProperties.clearAndSet(defaultRequestProperties);