From 026700a9d96a5f02d15300c3bb443b3ac2af928f Mon Sep 17 00:00:00 2001 From: Olivier Jouvenaux Date: Fri, 3 Jan 2025 09:28:43 +0100 Subject: [PATCH] Add unit tests for region attrs in style --- .../extractor/text/ttml/TtmlParserTest.java | 16 ++++++++++++++++ .../inherit_region_attributes_from_style.xml | 19 +++++++++++++++++++ 2 files changed, 35 insertions(+) create mode 100644 libraries/test_data/src/test/assets/media/ttml/inherit_region_attributes_from_style.xml diff --git a/libraries/extractor/src/test/java/androidx/media3/extractor/text/ttml/TtmlParserTest.java b/libraries/extractor/src/test/java/androidx/media3/extractor/text/ttml/TtmlParserTest.java index 38cee01100..09526c5376 100644 --- a/libraries/extractor/src/test/java/androidx/media3/extractor/text/ttml/TtmlParserTest.java +++ b/libraries/extractor/src/test/java/androidx/media3/extractor/text/ttml/TtmlParserTest.java @@ -74,6 +74,7 @@ public final class TtmlParserTest { private static final String RUBIES_FILE = "media/ttml/rubies.xml"; private static final String TEXT_EMPHASIS_FILE = "media/ttml/text_emphasis.xml"; private static final String SHEAR_FILE = "media/ttml/shear.xml"; + private static final String REGION_ATTRS_FROM_STYLE_FILE = "media/ttml/inherit_region_attributes_from_style.xml"; @Test public void simple_allCues() throws Exception { @@ -1093,6 +1094,21 @@ public final class TtmlParserTest { assertThat(eighthCue.shearDegrees).isWithin(0.01f).of(90f); } + @Test + public void regionAttrsFromStyle() throws Exception { + ImmutableList allCues = getAllCues(REGION_ATTRS_FROM_STYLE_FILE); + + Cue firstCue = Iterables.getOnlyElement(allCues.get(0).cues); + assertThat(firstCue.position).isEqualTo(10f / 100f); + assertThat(firstCue.line).isEqualTo(10f / 100f); + assertThat(firstCue.size).isEqualTo(20f / 100f); + + Cue secondCue = Iterables.getOnlyElement(allCues.get(1).cues); + assertThat(secondCue.position).isEqualTo(30f / 100f); + assertThat(secondCue.line).isEqualTo(30f / 100f); + assertThat(secondCue.size).isEqualTo(40f / 100f); + } + private static Spanned getOnlyCueTextAtIndex(List allCues, int index) { Cue cue = getOnlyCueAtIndex(allCues, index); assertThat(cue.text).isInstanceOf(Spanned.class); diff --git a/libraries/test_data/src/test/assets/media/ttml/inherit_region_attributes_from_style.xml b/libraries/test_data/src/test/assets/media/ttml/inherit_region_attributes_from_style.xml new file mode 100644 index 0000000000..56b1d3c189 --- /dev/null +++ b/libraries/test_data/src/test/assets/media/ttml/inherit_region_attributes_from_style.xml @@ -0,0 +1,19 @@ + + + +