From 00a5b33d241ca73c15a3232ec4aeae9e9bb654fe Mon Sep 17 00:00:00 2001 From: ibaker Date: Tue, 22 Feb 2022 13:34:24 +0000 Subject: [PATCH] Fix DefaultAnalyticsCollectorTest failure when run with JaCoCo #minor-release PiperOrigin-RevId: 430189385 --- .../analytics/DefaultAnalyticsCollectorTest.java | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libraries/exoplayer/src/test/java/androidx/media3/exoplayer/analytics/DefaultAnalyticsCollectorTest.java b/libraries/exoplayer/src/test/java/androidx/media3/exoplayer/analytics/DefaultAnalyticsCollectorTest.java index 7aff4de60f..968a6071d9 100644 --- a/libraries/exoplayer/src/test/java/androidx/media3/exoplayer/analytics/DefaultAnalyticsCollectorTest.java +++ b/libraries/exoplayer/src/test/java/androidx/media3/exoplayer/analytics/DefaultAnalyticsCollectorTest.java @@ -192,10 +192,18 @@ public final class DefaultAnalyticsCollectorTest { private EventWindowAndPeriodId window0Period1Seq0; private EventWindowAndPeriodId window1Period0Seq1; + /** + * Verify that {@link DefaultAnalyticsCollector} explicitly overrides all {@link Player.Listener} + * methods. + */ @Test public void defaultAnalyticsCollector_overridesAllPlayerListenerMethods() throws Exception { - // Verify that AnalyticsCollector forwards all Player.Listener methods to AnalyticsListener. for (Method method : Player.Listener.class.getDeclaredMethods()) { + if (method.isSynthetic()) { + // JaCoCo inserts synthetic methods. See "My code uses reflection. Why does it fail when I + // execute it with JaCoCo?": https://www.eclemma.org/jacoco/trunk/doc/faq.html + continue; + } assertThat( DefaultAnalyticsCollector.class .getMethod(method.getName(), method.getParameterTypes())