From 00859a78fd6ffaa447aade05253fdf1d8d11d36b Mon Sep 17 00:00:00 2001 From: kimvde Date: Tue, 6 Dec 2022 11:49:02 +0000 Subject: [PATCH] Add comment to explain why cancel exceptions are handled differently PiperOrigin-RevId: 493260798 --- .../java/androidx/media3/transformer/TransformerInternal.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libraries/transformer/src/main/java/androidx/media3/transformer/TransformerInternal.java b/libraries/transformer/src/main/java/androidx/media3/transformer/TransformerInternal.java index 90d3345514..01dc39bd35 100644 --- a/libraries/transformer/src/main/java/androidx/media3/transformer/TransformerInternal.java +++ b/libraries/transformer/src/main/java/androidx/media3/transformer/TransformerInternal.java @@ -334,6 +334,8 @@ import org.checkerframework.checker.nullness.qual.MonotonicNonNull; TransformationException.createForMuxer(e, ERROR_CODE_MUXING_FAILED); } catch (RuntimeException e) { releaseTransformationException = TransformationException.createForUnexpected(e); + // cancelException is not reported through a listener. It is thrown in cancel(), as this + // method is blocking. cancelException = e; } // Quit thread lazily so that all events that got triggered when releasing the AssetLoader are